Repository navigation
perf: inline module hot lookup dispatch - #125
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline the already-validated thread-local module hot entry directly into
_module_lookup, avoiding a redundant_module_compilecall and repeated default-shape checks on module-levelmatch,search,fullmatch,findall, andfinditer._module_compilefallback when it is monkeypatched or a legacy backend is in use.Local free-threaded benchmark (3.14t): module.match 0.700 -> 0.596 us, module.search 0.705 -> 0.600 us, module.fullmatch 0.736 -> 0.626 us, module.findall 0.632 -> 0.533 us, module.finditer 1.778 -> 1.617 us.
Validation: 908 passed, 14 skipped, 545 subtests; debug-allocator thread/cache suite 83 passed. Version remains 0.6.4.