fix: setup.py python_requires stale at >=3.9.16, docs require 3.10 - #1503
Open
PARINAYKAPOOR wants to merge 1 commit into
Open
fix: setup.py python_requires stale at >=3.9.16, docs require 3.10#1503PARINAYKAPOOR wants to merge 1 commit into
PARINAYKAPOOR wants to merge 1 commit into
Conversation
….10 requirement The installation docs (docs/EN/source/getting_started/installation.rst) require Python 3.10, but setup.py's python_requires still allowed Python 3.9.16+. This let pip proceed on Python 3.9 and fail deep inside dependency resolution (e.g. flashinfer-python requiring >=3.10) instead of surfacing a clear "Python >=3.10 required" error immediately. Fixes part of ModelTC#1179.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #1179.
The installation docs (
docs/EN/source/getting_started/installation.rst) require Python 3.10, butsetup.py'spython_requiresstill said>=3.9.16. This letspip installproceed on Python 3.9 and fail deep inside dependency resolution (e.g.flashinfer-pythonrequiring >=3.10) instead of surfacing a clear "Python >=3.10 required" error immediately.Note: the
sgl-kernel==0.3.7.post1version-pin issue also reported in #1179 appears to already be resolved onmain(nowsglang-kernel==0.4.2.post1), so this PR addresses the remaining root cause: the stalepython_requiresmetadata.Test plan
conda create -n lightllm python=3.10example).setup.pywas out of sync (>=3.9.16) with that documented requirement.