fix(chrome): lift tab strips, table headers and the scope chip one contrast step - #442
Merged
Conversation
…ntrast step Chart tab strips, every MoonDataTable header and the pinned-scope chip draw their labels in text_muted, which sits at 3.5-3.8:1 against the panel in both themes, under the 4.5:1 floor at the user's font size. Add one design::chrome_label_color helper resolving to text_soft (6.7-7.0:1 light, 5.1-5.5:1 dark) and apply it at six tab strips, all nine table construction sites and the chip; three tab hosts had to learn (window, cx) to reach the themed render path. The dock tab strip itself is drawn inside MoonUI with no styling knob and is left as a MoonUI request. Claude-Session: https://claude.ai/code/session_01RaQ2tnAyr4pyiAiwGktPBv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Table headers, chart tab strips, the expert core-settings tabs and the pinned-scope chip all sat one contrast step below legible on the light theme. Each moves up one step through
design::chrome_tab_strip/MoonTableStyle::header_text; a sorted column now differs by its arrow only. Dock tab labels are MoonUI-forced and stay as they are.How to verify
https://claude.ai/code/session_01RaQ2tnAyr4yiwGktPBv