feat(data-table): visible light-theme row hover and a header tooltip - #61
Merged
Merged
Conversation
Row hover: `table_hover` resolved from `panel_high`, which the light palette sets to pure white, so a hovered row on a white table was invisible. The palette gains its own `table_hover` key (dark keeps the former panel_high value, light takes the gutter step 0xEEF2F6) and the theme role reads it. `MoonPalette` is `#[serde(default)]`, so a theme file without the key keeps working. Header tooltip: `MoonDataTableColumn` gains an optional `tooltip` and a builder; the header cell attaches a `MoonTooltipView` when it is set. A consumer that relabels a technical column can keep the raw name one hover away.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row hover:
table_hoverresolved frompanel_high, which the lightpalette sets to pure white, so a hovered row on a white table was
invisible. The palette gains its own
table_hoverkey (dark keeps theformer panel_high value, light takes the gutter step 0xEEF2F6) and the
theme role reads it.
MoonPaletteis#[serde(default)], so a themefile without the key keeps working.
Header tooltip:
MoonDataTableColumngains an optionaltooltipand abuilder; the header cell attaches a
MoonTooltipViewwhen it is set.A consumer that relabels a technical column can keep the raw name one
hover away.