[pull] main from astral-sh:main - #252
Merged
Merged
Conversation
Related to #20852 and follow-up to #21270. The `trampoline_repro_changed` filter in `plan.yml` watches `rust-toolchain.toml`, `.rs` sources and the prebuilt `trampolines/` binaries, but not `crates/uv-trampoline/Dockerfile`. Since the Dockerfile pins `RUST_NIGHTLY` (currently `nightly-2026-03-11`, matching the toolchain file), a Dockerfile-only change would skip the reproducibility check while altering the build environment. This adds the Dockerfile to the filter so such changes trigger `test_windows_trampoline_check_binary`.
When `dependency-metadata` adds dependencies to an already installed package, we can incorrectly treat the environment as satisfied because the install fast path reads the wheel's original metadata. For example, requesting an extra added by configured metadata can succeed without installing its dependencies. Removing published dependencies through configured metadata can also cause repeated resolution of an otherwise satisfied environment. Use matching configured metadata when traversing installed dependencies, falling back to the distribution's metadata when no entry matches. Pass the metadata through the shared checks used by pip installs, project environments, and tools. Extra markers, overrides, exclusions, and `--no-deps` continue to apply to that traversal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )