Repository navigation
菜单栏:切到无缓存周期加载期间保持面板高度 - #268
Merged
moshui-claude-code-macmini[bot] merged 2 commits intoOct 6, 2026
Merged
moshui-claude-code-macmini[bot] merged 2 commits into
moshui-claude-code-macmini[bot] merged 2 commits into
Conversation
切到无缓存周期时加载期间用量区与设备卡片被一行提示替换,面板先塌缩、约 1 秒后数据到达 再撑开,表现为上下错位。记录数据就绪时的整窗高度,加载期间作为最小高度托住面板, 数据到达后一次调整到位。 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
CI 虚拟机屏幕小(上限约 633pt),原断言「数据到达后比切换前高 50」在上限附近失败;改为 起始离上限留出空间、增长断言夹在上限内。新增反向守卫:数据到达后变矮必须收回,再次切换 托住新的较小高度(「永远托住」变异下变红)。加载完成前先等请求登记,避免时序抖动。 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
CI 失败与审查处理
|
moshui-claude-code-macmini
Bot
deleted the
claude/menubar-hold-height-while-loading
branch
October 6, 2026 03:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更(Refs #267)
MenuBarPopoverView:@State settledHeight记录数据就绪时的整窗高度(GeometryReader,加载期间不更新);isLoading && !hasLoadedUsableSummary时整窗.frame(minHeight: min(settledHeight, maxPopoverHeight), alignment: .top),提示文字在顶部、下方留白;数据到达后取消最小高度,一次调整到新高度。首次打开无数据时 settledHeight=0,无影响;上限仍由 #264 的maxPopoverHeight约束。诊断(本机 Xcode 27 / XCTest,临时逐 8ms 记录,未提交)
测试(先红后绿,本机)
testSwitchingToUncachedPeriodKeepsPopoverHeightWhileLoading:切换前整窗 > 300(结构下限);加载期间preferredContentSize≥ 切换前 − 1;数据到达后 > 切换前 + 50。XCTAssertGreaterThanOrEqual failed: ("255.0") is less than ("627.0") - 加载期间面板不得塌缩。MenuBarAppModelTests55 条 0 失败。🤖 Generated with Claude Code