Repository navigation
fix(ray): finish the uni_ray to uniray caster rename - #2601
Merged
Merged
Conversation
uniray 0.1.1 renamed the plugin import namespace and UniSim factory identity from ``uni_ray`` to ``uniray``; unisim-core 2.2+ only declares the ``uniray`` spec. Three leftovers still referenced the old spelling: - ``RayPatternCfg.caster`` defaulted to the dead name, so any task relying on the default failed caster construction against the pinned unisim-core. - Two tests gated on the old import namespace skipped or asserted the stale default. - The sim2sim contract compared ``caster`` verbatim, so every checkpoint trained before the rename failed the strict ``env.observations`` DENYLIST comparison on play even though ray numerics and policy I/O are unchanged. Rename the default, update the tests to the ``uniray`` namespace, and canonicalize caster identity values through ``CASTER_VALUE_ALIASES`` on both sides of every contract comparison. Only the documented rename is exempt; switching to a different caster still fails closed. Discovered by the downstream perceptive navigation port: the trained navigation checkpoints snapshot ``caster: uni_ray`` and could not play against the renamed conf without this normalization. Commands: uv run pytest tests/training/test_sim2sim_resolver.py tests/envs/mdp/test_ray_observation.py -q (79 passed); make check Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uniray 0.1.1 renamed the plugin import namespace and UniSim factory identity from
uni_raytouniray; unisim-core 2.2+ only declares theunirayspec. Three leftovers still referenced the old spelling:RayPatternCfg.casterdefaulted to the dead name — any task relying on the default failed caster construction against the pinned unisim-core.pytest.importorskip("uni_ray")skips the end-to-end MuJoCo ray test even when uniray 0.1.1 is installed; one test asserted the stale default.casterverbatim — every checkpoint trained before the rename fails the strictenv.observationsDENYLIST comparison on play, although the rename changes no ray numerics and no policy I/O.Fix: rename the default to
uniray, update tests to theuniraynamespace, and canonicalize caster identity values through a newCASTER_VALUE_ALIASES = {"uni_ray": "uniray"}on both sides of every contract comparison. Only the documented rename is exempt — switching to a different caster (e.g.fake) still fails closed.Discovered by the downstream perceptive navigation port: trained checkpoints snapshot
caster: uni_rayand could not play against the renamed conf without this normalization.Linked Work
mainValidation
make test-all: tracked with remote CICommands actually run:
Remote CI route:
main: will run on this PR's head.Impact
mujoco(ray perception path only)Artifacts
Checklist
Made with Cursor