Repository navigation
Allow for resuming downloads without counting for rate limiting - #161
Merged
Merged
Conversation
…ive-python into persist-presigned-url # Conflicts: # docs/index.md # src/datacollective/download.py # tests/test_download.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resume with stored presigned URL
Interrupted downloads used to cost a new download session every time, which counts towards the API's daily download limit. This PR reuses the presigned URL the SDK already has.
.checksumsidecar now holds JSON with the checksum, the presigned URL, itsexpiresAtand the archive size. On the next run, if the.partfile exists and the URL has not expired, the download resumes from it without calling the download endpoint. If the storage rejects the URL anyway, the SDK falls back to requesting a new one and still resumes the partial file. A plain-text sidecar from an older SDK version is still read as a bare checksum.expiresAtis required.