Repository navigation
fix(free): keep focus after removing a selected chip (#288) - #289
Merged
Merged
Conversation
Focus the remaining chip, or the search field or Clear when it was the last. Do not leave focus on body.
Headless Chrome scrolls an off-screen chip into view before preventScroll applies. Restore the pre-click scroll and keep focus on the remaining chip.
This was referenced Oct 15, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
document.activeElementis notbody. Focus usespreventScrollso the page does not jump. The no-JS submit path is unchanged.Lab proof
Chrome 148 on http://127.0.0.1:18092, after copying this
free-selection.jsinto the running acceptance lab:button.writeleash-chip__remove(Remove Harbor Tee…), notbody. Scroll delta 0.#writeleash-free-product_search, notbody.Local
bash .github/ci/pr-fast.sh:#133 PR_FAST PASS.Do not merge. Only @MrDarkRoot merges.
Fixes #288