Repository navigation
docs+test(free): freeze price-write boundary and correct PERMISSION_REVOKED (#295) - #301
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authorization
Founder GO: #295 comment 2026-10-15T13:47:48Z (boundary + copy only) under #294 P0 GO. Scope is #295 only.
Base / head
aaf7dff9603a947feb630776908229e19fc5793c(fetched origin/main at implementation time).Scope (7 files, +163/-1)
FREE-PRICE-APPLY-CONTRACT.md: dated [v0.3.0] Freeze the price-write boundary as a tested contract #295 supersession banner (in-scope writers, out-of-scope list, save()-hook caveat, plan.actor_id principal, clicker note, frozen policy, entry points, tripwire limits). Historical text untouched.FREE-JOB-ENGINE-CONTRACT.md: dated cross-link superseding the stale REST-only resume sentence; sentence retained.class-job-state.php: PERMISSION_REVOKED now names the preview creator (plan actor). Authorization untouched. Undo wording verified matching initiator_id, unchanged..potuntouched (no workflow requires same-change catalog refresh; i18n-catalog passes).tests/jobs/price-write-allowlist.php(new): full-tree file-and-symbol allowlist + copy regression + 5 negative controls on temp trees.in-container.sh: wire the check next to no-replan-audit.Tests
php wordpress/tests/jobs/price-write-allowlist.php wordpress/writeleash-> exit 0: 61 files scanned, 5 negatives fail-closed with file+op diagnostics, copy assertion PASS.php wordpress/tests/jobs/no-replan-audit.php wordpress/writeleash-> exit 0.php wordpress/tests/admin/i18n-catalog.php-> exit 0 (610 entries).bash .github/ci/pr-fast.sh-> exit 0, PR_FAST PASS (lint 226 files).Risks
Token scan misses variable methods, concatenated names, raw SQL (stated in test output + banner); paired with runtime mutation suites.
.potrefresh deferred to the normal catalog workflow.Maintainer: inspect diff + CI before merge. Do not merge until jobs/undo/admin workflows pass.