馃悰 Filter the games library by type instead of excluding anime - #27
Open
coltons-qa wants to merge 1 commit into
Open
coltons-qa wants to merge 1 commit into
coltons-qa wants to merge 1 commit into
Conversation
Any note whose type was not "anime" was parsed as a game, so vaults that keep several media types in one folder saw tv shows, movies, and books in the games library. The reverse did not happen: the tv, movie, and book services each match their own type, so they correctly ignored games. The check dates from the initial release, when the plugin held only games and anime and "not anime" really did mean "game". The 2.0.0 media libraries added the other types without inverting it. Match the sibling services: keep a note when its type is "game", or when it has no type at all so hand-written notes still appear. Trim the value first, as VideoService and ReadingService already do. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
coltons-qa
marked this pull request as ready for review
August 14, 2026 22:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your work, I'm really enjoying getting Lorebase set up!
Issue: Any note whose type was not "anime" was parsed as a game, so vaults that keep several media types in one folder saw series, movies, manga, and books in the games library.
Repro:
Probably just an artifact from when only games an anime were supported. Edited to match the filtering conventions for other media types: keep a note when its type is "game", or when it has no type at all so hand-written notes still appear. Trim the value first, as VideoService and ReadingService already do.