Fix PersistenceLocationAnalyzer and UniquePlacedNpcAnalyzerissues - #643
Open
kieranknowles1 wants to merge 9 commits into
Open
kieranknowles1 wants to merge 9 commits into
kieranknowles1 wants to merge 9 commits into
Conversation
This is a duplicate of Mutagen-Modding#386 NotInsidePersistenceLocation and never worked because: - UniquePlacedNpcAnalyzer didn't list any topics - it attempted to get the base NPCs parent as a cell, rather than the PlacedNpc - It errored on an NPC being inside its persist location rather than outside - It did not include virtual location or persist all
Member
Contributor
Author
The current title of #385 and #386 is misleading, as the topics are implemented in Npc.PersistenceLocationAnalyzer which runs on placed NPCs, this could be promoted to run on IPlaced instead as the same logic is applicable |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UniqueNpcWithoutPersistenceLocationnot being exposed from TopicsPersistenceLocationWithCellWithoutLocationnot including locations inherited from worldspaceTopicsproperty (don't know if this is following best Xunit/Autofac practices).Topicsfor several analysers