Repository navigation
fix: last_month et last_month_last_year valent 0 le 1er du mois (Refs #640) - #641
Open
Marlboro62 wants to merge 1 commit into
Open
Marlboro62 wants to merge 1 commit into
Marlboro62 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problème
Le 1er du mois (date UTC),
last_month()etlast_month_last_year()calculentendà partir de
yesterday_date. La veille tombe alors dans le mois précédent, doncendse retrouve au dernier jour du mois d'avant : la période est inversée (begin > end)
et la somme vaut 0.
Correctif
endest calculé à partir denow_dateau lieu deyesterday_date. La variableyesterday_date, devenue inutilisée dans ces deux fonctions, est retirée.Vérification (date simulée dans le conteneur)
last_month_last_year()se comporte de la même façon. Aucun changement hors du 1er du mois.Hors périmètre
current_month()renvoie 0 le 1er : c'est cohérent, il n'existe encore aucune journéecomplète dans le nouveau mois. Non modifié.
last_year()(replace(month=1, …)au lieu demonth=12) : non traité ici, lafonction est réécrite dans feat: configurable annual period start date (annual_period_start) #637.