Skip to content

initialize doscalar to .false. in mpi{f08} utilities - #1182

Merged
hkershaw-brown merged 1 commit into
mainfrom
doscalar-init
Sep 10, 2026
Merged

hkershaw-brown merged 1 commit into
mainfrom
doscalar-init

Conversation

@hkershaw-brown

Copy link
Copy Markdown
Collaborator

Description:

Please provide a summary of the change and include any relevant motivation and context.

mpi utilties and mpif08 utitlies use countup to "figure out how many items are in the specified arrays, total.
also note if there's more than a single array (array1) to send, and if there are any scalars specified."

The intent(out) doscalar is not set unless a scalar is present. If no scalar is present, doscalar is undefined on return.
This pull request initializes doscalar to .false.

null_mpi_utitiles does not use countup.

Fixes issue

fixes #1169

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@mjs2369 mjs2369 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@hkershaw-brown hkershaw-brown added the release! bundle with next release label Sep 9, 2026
was uninitialized
fixes #1169
@hkershaw-brown
hkershaw-brown merged commit 6eac0df into main Sep 10, 2026
13 checks passed
@hkershaw-brown
hkershaw-brown deleted the doscalar-init branch September 10, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release! bundle with next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doscalar is intent(out) and uninitialized if there are no scalars in subroutine countup

2 participants