initialize doscalar to .false. in mpi{f08} utilities - #1182
Merged
Merged
Conversation
hkershaw-brown
force-pushed
the
doscalar-init
branch
from
August 28, 2026 16:49
6093754 to
4f50163
Compare
mjs2369
self-requested a review
September 3, 2026 21:05
was uninitialized fixes #1169
hkershaw-brown
force-pushed
the
doscalar-init
branch
from
September 10, 2026 17:59
4f50163 to
f6d4b16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Please provide a summary of the change and include any relevant motivation and context.
mpi utilties and mpif08 utitlies use
countupto "figure out how many items are in the specified arrays, total.also note if there's more than a single array (array1) to send, and if there are any scalars specified."
The intent(out) doscalar is not set unless a scalar is present. If no scalar is present, doscalar is undefined on return.
This pull request initializes doscalar to .false.
null_mpi_utitiles does not use
countup.Fixes issue
fixes #1169
Types of changes
Documentation changes needed?
Tests
Please describe any tests you ran to verify your changes.
Checklist for merging
Checklist for release
Testing Datasets