Skip to content

fix(observability): start correlation grace after queue #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rldyourmnd merged 2 commits into from
Aug 27, 2026
Merged

fix(observability): start correlation grace after queue #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b958031
fix(observability): start correlation grace after queue
rldyourmnd Aug 27, 2026
261864d
fix(observability): page correlation only after running
rldyourmnd Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions internal/fleetobserve/observe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,10 +593,14 @@ func summarizeQueue(snapshot queueintent.Snapshot, platform config.Config, now t
}
summary.ByPriority[intent.Priority]++
summary.ByScaleSet[intent.ScaleSetName]++
correlationAge := now.Sub(intent.QueueTime)
correlationSince := intent.QueueTime
if intent.State != queueintent.StateQueued {
correlationSince = intent.StateEnteredAt
}
correlationAge := now.Sub(correlationSince)
if !strings.Contains(intent.Repository, "/") {
summary.UnboundRepository++
if intent.State != queueintent.StateQueued && correlationAge >= queueCorrelationGracePeriod {
if intent.State == queueintent.StateRunning && correlationAge >= queueCorrelationGracePeriod {
summary.UnboundRepositoryBeyondGrace++
}
}
Expand All @@ -613,7 +617,7 @@ func summarizeQueue(snapshot queueintent.Snapshot, platform config.Config, now t
// without a workflow-run identity; the authenticated runner claim
// supplies that identity after assignment. Keep the raw gap visible,
// but page only after the intent has actually left the queue.
if intent.State != queueintent.StateQueued && correlationAge >= queueCorrelationGracePeriod {
if intent.State == queueintent.StateRunning && correlationAge >= queueCorrelationGracePeriod {
summary.MissingWorkflowRunIDBeyondGrace++
}
}
Expand Down
21 changes: 21 additions & 0 deletions internal/fleetobserve/observe_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,8 @@ func TestQueueSummarySeparatesTransientAndPersistentCorrelationGaps(t *testing.T
persistent.Key = "persistent"
persistent.JobID = "6c3077ba-3664-5824-b2cf-e22a31b25f44"
persistent.QueueTime = observationTime.Add(-queueCorrelationGracePeriod)
persistent.StateEnteredAt = observationTime.Add(-queueCorrelationGracePeriod)
persistent.State = queueintent.StateRunning
summary, err := summarizeQueue(queueintent.Snapshot{Active: []queueintent.Intent{transient, persistent}}, testPlatform(t), observationTime)
if err != nil {
t.Fatal(err)
Expand Down Expand Up @@ -304,6 +306,25 @@ func TestQueueSummaryDoesNotPageOnRehydratedJobWaitingForCapacity(t *testing.T)
}
}

func TestQueueSummaryDoesNotPageAssignedCapacityWait(t *testing.T) {
assigned := queueintent.Intent{
Key: "assigned-rehydrated", ScaleSetID: 11, JobID: "6c3077ba-3664-5824-b2cf-e22a31b25f44",
ScaleSetName: "nddev-linux-integration", Repository: "owner",
WorkflowRef: "authoritative-rehydration", EventName: "push",
QueueTime: observationTime.Add(-10 * queueCorrelationGracePeriod),
State: queueintent.StateAssigned, Priority: 1,
StateEnteredAt: observationTime.Add(-10 * queueCorrelationGracePeriod), UpdatedAt: observationTime.Add(-time.Second),
ExpiresAt: observationTime.Add(time.Minute),
}
summary, err := summarizeQueue(queueintent.Snapshot{Active: []queueintent.Intent{assigned}}, testPlatform(t), observationTime)
if err != nil {
t.Fatal(err)
}
if summary.MissingWorkflowRunIDBeyondGrace != 0 || summary.UnboundRepositoryBeyondGrace != 0 {
t.Fatalf("newly assigned correlation classification = %#v", summary)
}
}

func TestCollectorMarksRunningIntentWithoutExecutionLeaseUnhealthy(t *testing.T) {
collector := healthyCollector(t)
collector.Journal = func(context.Context) (providerjournal.Journal, error) {
Expand Down