Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion internal/observabilityrules/openobserve.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,10 @@ func RenderOpenObserve(bundle Bundle, destination string, enable bool) (OpenObse
}
for _, rule := range bundle.Rules {
priority := 3
silence := 60
// OpenObserve v0.92 pauses outcome evaluation during silence rather
// than suppressing notification delivery alone. Keep ticket recovery
// fresh enough to trust while still spacing repeat notifications.
silence := 15
if rule.Severity == "page" {
priority = 1
silence = 10
Expand Down
20 changes: 20 additions & 0 deletions internal/observabilityrules/rules_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -160,3 +160,23 @@ func TestRenderOpenObserveConvertsSecondsToMinuteSchedule(t *testing.T) {
})
}
}

func TestRenderOpenObserveBoundsStaleRecoveryDuringSilence(t *testing.T) {
bundle, err := Load("../../config/observability-rules.yaml")
if err != nil {
t.Fatal(err)
}
rendered, err := RenderOpenObserve(bundle, "fleet_oncall", true)
if err != nil {
t.Fatal(err)
}
for index, alert := range rendered.Alerts {
want := 15
if bundle.Rules[index].Severity == "page" {
want = 10
}
if alert.TriggerCondition.Silence != want {
t.Fatalf("alert %s silence=%d, want %d", alert.Name, alert.TriggerCondition.Silence, want)
}
}
}