Repository navigation
Fix initialization retry and concurrent completion semantics (#85) - #98
Merged
Merged
Conversation
AGiorgetti
force-pushed
the
feature/fix-initialization-retry-85
branch
from
October 29, 2026 10:17
def0073 to
527e8e7
Compare
AGiorgetti
marked this pull request as ready for review
October 29, 2026 10:24
On unchanged product code: 5 failing regressions, 1 passing idempotence test. Cover index/checkpoint setup, shared concurrent outcomes, and recursive entry. Co-authored by Alessandro Giorgetti and Codex (OpenAI).
Publish success after setup, let concurrent callers join the same attempt, and reject recursive initialization without poisoning a running attempt. Co-authored by Alessandro Giorgetti and Codex (OpenAI).
AGiorgetti
force-pushed
the
feature/fix-initialization-retry-85
branch
from
November 1, 2026 12:59
527e8e7 to
2f74d41
Compare
Co-authored by Alessandro Giorgetti and Codex (OpenAI).
…lag (#85) Serialize callers; retry after failure and retain successful initialization. Use System.Threading.Lock for net9.0+ and object for older targets. Co-authored by Alessandro Giorgetti and Codex (OpenAI).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Addresses #85 independently of #87 and #86, now rebased onto develop bc30a39 (including #101).
System.Threading.Lockon .NET 9+ and an object lock on older targets; retain a success flag instead ofLazy<bool>.finally, including when a recursive exception escapes.Historical tests-first validation (before the simplification)
The original first commit, 13bf041, contains only permanent regression tests. The historical red-test validation below used the original test commit 75ddea0.
Against unchanged product code on MongoDB 7.0.45 / net8.0: 5 failed, 1 passed, 0 skipped.
Six scenarios cover real index-conflict retry, checkpoint-constructor failure after indexes succeed, successful idempotence, gated concurrent success/failure, and caught recursive entry. Those historical tests required concurrent waiters to observe the same failed attempt; the November 2 simplification intentionally replaces that contract with serialized retries. Tests use gates and thread state, not a timing benchmark, and follow Context/Because/Fact conventions.
The recursion regression also caught and rejected an intermediate implementation that could poison Lazy state; the guard at that historical revision passed it.
Historical local validation (before the current rebase)
Previously validated tree: 399ca0fd95914fdfb87c57970e9223001555e90e.
Local database: MongoDB 7.0.45. MongoDB 8 cannot start on this cloud host because required /sys CPU metadata is unavailable; PR CI at that time used MongoDB 8. net472 was compiled, not executed on Linux. No timing benchmarks. No package, workflow or unrelated fix changes.
Historical GitHub CI
CI run 39969206709 succeeded on head 3fb5929: Ubuntu and Windows builds and all MongoDB 8 Linux net8.0/net9.0/net10.0 test jobs passed. No reruns were needed.
Do not merge or publish packages.
Historical rebase validation (2026-11-01)
Head:
2f74d41cddd80d40d4e16f0b75e23637df4b25eb; tree:a57996e4be797e13259ff50947da5afb111398e0.git range-diff;git diff --checkpassed.mongo:9.0.4image. No driver or runner changes were added by this rebase.mongo:9.0.4; each test job reported 285 passed, 0 failed, 0 skipped.Initialization simplification (2026-11-02)
Head:
9ab5162ac865b3fd87a842e1a643c95fd865a23f.Lazy<bool>attempts with one lock, a success flag, and a recursion guard. Successful initialization remains idempotent; failed initialization releases the lock so the next waiting caller can retry.git diff --checkpassed. Exact-head CI 41525433716 passed on the first attempt: Windows and Ubuntu solution builds succeeded; Linux net8.0/net9.0/net10.0 each reported 286 passed, 0 failed, 0 skipped with MongoDB 9.0.4. This exercises the object-lock path on net8.0 and System.Threading.Lock on net9.0/net10.0. Other target frameworks were compiled, not runtime-tested by this CI matrix.Co-authored by Alessandro Giorgetti and Codex (OpenAI).