Skip to content

[WIP] Add tests for experiment_check function in helpers.py - #984

Open
singhd789 with Copilot wants to merge 11 commits into
mainfrom
copilot/975-add-tests-experiment-check
Open

singhd789 with Copilot wants to merge 11 commits into
mainfrom
copilot/975-add-tests-experiment-check

Conversation

Copilot AI commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor
  • Confirm the checked-out branch is associated with PR 874.refactor fre yamltools #975 and inspect experiment_check plus existing helper-test conventions.
  • Add focused pytest coverage for successful path resolution and documented validation failures/optional analysis behavior.
  • Run targeted tests (12 passed), review the diff, scan changed files for secrets, and validate the final change.

Copilot AI balanced review requested due to automatic review settings October 8, 2026 18:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

Co-authored-by: singhd789 <115384427+singhd789@users.noreply.github.com>
Comment thread fre/yamltools/tests/test_helpers.py Outdated
Comment thread fre/yamltools/tests/test_helpers.py Outdated
Comment thread fre/yamltools/tests/test_helpers.py Outdated
Copilot stopped work on behalf of singhd789 due to an error October 8, 2026 19:27
Copilot AI requested a review from singhd789 October 8, 2026 19:27
Copilot stopped work on behalf of singhd789 due to an error October 8, 2026 19:39
Co-authored-by: singhd789 <115384427+singhd789@users.noreply.github.com>
Co-authored-by: singhd789 <115384427+singhd789@users.noreply.github.com>
Co-authored-by: singhd789 <115384427+singhd789@users.noreply.github.com>
@singhd789
singhd789 marked this pull request as ready for review October 8, 2026 20:22
@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.60%. Comparing base (e9f3df4) to head (a930e69).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #984      +/-   ##
==========================================
+ Coverage   83.46%   83.60%   +0.13%     
==========================================
  Files          68       68              
  Lines        3811     3811              
==========================================
+ Hits         3181     3186       +5     
+ Misses        630      625       -5     
Flag Coverage Δ
unittests 83.60% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9f3df4...a930e69. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@singhd789
singhd789 requested a review from ceblanton October 8, 2026 20:34
@singhd789

singhd789 commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

I think these tests will help the yamltools refactor PR succeed (#975). Since they are tests, I don't think we necessarily need the build_conda pipeline to be successful here.

@singhd789 singhd789 mentioned this pull request Oct 15, 2026
8 tasks done
@singhd789
singhd789 requested review from Ciheim and ilaflott and a balanced review from Copilot October 15, 2026 16:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The test-only changes match the helper’s behavior, with no blocking issues identified.

0 open findings

🧠 Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants