Skip to content

Is screensaver2 meant to be gone from the HMI after #419? #427

Open

Description

@jamesmulcahy

Hi @tpanajott @Aulos, thanks for the cover support, it's a nice addition. I noticed something while bumping the HMI I test against, and I'm not sure whether it's intended or whether I'm misreading it.

Both #419 and NSPManager/NSPanelManager-firmware#55 say:

Page cover, on its own HMI page slot. screensaver2 keeps its role as the "screensaver without weather" page and is not reused.

But in the gui.HMI merged in #419 (US and EU), the cover page seems to sit in slot 4, where screensaver2 was, and I can't find screensaver2 anywhere:

Slot Before #419 (38f74e2) After #419 (c5586ef)
3 screensaver screensaver
4 screensaver2 cover
5 dropdown dropdown

Both files have 12 pages and are exactly the same size, and the string screensaver2 no longer appears in either the US or the EU HMI.

The firmware on devel still uses screensaver2 for the clock-only and no-screensaver modes (ScreensaverPage.cpp sends page screensaver2 for DATETIME_WITH_BACKGROUND, DATETIME_WITHOUT_BACKGROUND and NO_SCREENSAVER, and GUI_data.hpp has its labels). So I'd expect a TFT built from this HMI to reject those commands with 0x1A.

I only compared the .HMI sources, not the built .tft files, so it's quite possible the released TFTs are fine and I'm missing something. Is this what you intended, or did screensaver2 get replaced by accident?

Activity

  1. jamesmulcahy commented on Nov 8, 2026

    @jamesmulcahy
    ContributorAuthor

    Following up on this: since the HMIs are binary, it's hard to spot this kind of change in review, so I've opened #428 (draft). It commits a text inventory of each HMI (pages, components, attributes, event code), checked in CI, so an HMI change shows up as a normal diff. For #419 that diff would have been:

    -## page 4 screensaver2
    -[0] screensaver2  page  global
    +## page 4 cover
    +[0] cover  page

    It also compares the US and EU HMIs with each other. Most of the differences are layout (vertical vs horizontal sliders, fonts, alignment), but a few look like changes that made it into one file and not the other. I haven't checked these against the firmware, so I may be wrong about some:

    • dropdown.tc0 (up): the EU has a swipe to the thermostat page (tc0.val==18) that the US doesn't.
    • thermostat.prev / next (down): the EU sends deactivatetemp and stops setTempTimer if a setpoint change is pending; the US doesn't.
    • items4 / items8 / items12 (load): the EU hides slider_save (vis slider_save,0); the US doesn't.
    • dropdown.i1_button…i6_button and dropdown.current are global on the US and local on the EU.
    • items4.i1_button…i4_button have txt_maxl 1 on the US and 10 on the EU.

    The full list, with my guess at which differences are intended, is in hmi_us_eu_differences.txt on the PR. Corrections are very welcome. Anything you know is intended can be marked expected with a reason.

  2. cablesandcoffee commented on Nov 8, 2026

    @cablesandcoffee
    Collaborator

    Wow @jamesmulcahy you find everything! This is great. I think most is probably not intended just me missing stuff when copying and pasting when editing the two files. The screensaver2 missing is a mistake. The change proposer renamed it to cover and did the cover work there. I'm just starting the work to fix that so Ill add a new page and implement it on both EU and US. While doing that I can take a look at the difference list you created. Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions