Skip to content

test(slurm): stabilize CLI truncation fixture - #1101

Merged
andreatnvidia merged 1 commit into
feat/slurm-executionfrom
andreatnvidia/fix/slurm-cli-diagnostic
Oct 28, 2026
Merged

andreatnvidia merged 1 commit into
feat/slurm-executionfrom
andreatnvidia/fix/slurm-cli-diagnostic

Conversation

@andreatnvidia

Copy link
Copy Markdown
Contributor

Summary

The Slurm CI job in #1040 fails because the diagnostic truncation test assumes the temporary file path makes the message exceed 512 characters. Shorter runner paths produce a valid 501-character message instead.

Related Issue

Addresses the failing Slurm test in #1040. Targets feat/slurm-execution.

Changes

  • Add a long parent directory to the test fixture so the diagnostic reliably exceeds the limit.
  • Preserve the exact 512-character and trailing-ellipsis assertions.

Testing

  • Reproduced the original failure locally with a short temporary path (503 characters).
  • All 46 CLI tests pass with a short temporary path after the fix.
  • The truncation test also passes with the default temporary path.
  • Ruff lint and format checks pass for the changed file; git diff --check passes.
  • Full workspace tests and GPU tests not run for this test-only change.

Checklist

  • Follows commit message conventions.
  • Unit test updated.
  • DCO: no sign-off trailer added.
  • External-contributor triage, E2E tests, and architecture docs: N/A.

@andreatnvidia
andreatnvidia requested a review from a team as a code owner October 28, 2026 13:17
@greptile-apps

greptile-apps Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This test-only change appears safe to merge.

Summary

This test-only change adds a long parent directory so the Slurm CLI truncation test no longer depends on the temporary path's length.

  • The CLI truncation test always builds a long enough input path.

Reviews (1) · Last reviewed commit: "test(slurm): stabilize CLI truncation fi..." · Reviewed by Greptile

@svcnvidia-nemo-ci svcnvidia-nemo-ci left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No merge-blocking defects found. The updated fixture makes the validation diagnostic exceed 512 characters even with short temporary paths, while retaining the exact-length and trailing-ellipsis assertions. Checked fixture creation, test isolation, and the config-loading/error-emission path against the base version.

Static review only; tests were not executed.

Note: formal approval is not available for this request, so this review is posted as a comment only.

Review generated by codex. This was a full review. Request a full review with /review reset=true.

@andreatnvidia
andreatnvidia merged commit 0a5b0e7 into feat/slurm-execution Oct 28, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants