Repository navigation
test(slurm): stabilize CLI truncation fixture - #1101
Conversation
[Low impact] This test-only change appears safe to merge. SummaryThis test-only change adds a long parent directory so the Slurm CLI truncation test no longer depends on the temporary path's length.
Reviews (1) · Last reviewed commit: "test(slurm): stabilize CLI truncation fi..." · Reviewed by Greptile |
svcnvidia-nemo-ci
left a comment
There was a problem hiding this comment.
No merge-blocking defects found. The updated fixture makes the validation diagnostic exceed 512 characters even with short temporary paths, while retaining the exact-length and trailing-ellipsis assertions. Checked fixture creation, test isolation, and the config-loading/error-emission path against the base version.
Static review only; tests were not executed.
Note: formal approval is not available for this request, so this review is posted as a comment only.
Review generated by codex. This was a full review. Request a full review with /review reset=true.
Summary
The Slurm CI job in #1040 fails because the diagnostic truncation test assumes the temporary file path makes the message exceed 512 characters. Shorter runner paths produce a valid 501-character message instead.
Related Issue
Addresses the failing Slurm test in #1040. Targets
feat/slurm-execution.Changes
Testing
git diff --checkpasses.Checklist