Skip to content

chore: allow huggingface-hub 2.x #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davanstrien wants to merge 3 commits into
base: main
Choose a base branch
from
+102 −57
Open

chore: allow huggingface-hub 2.x #1117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f41e6f2
chore: allow huggingface-hub 2.x
davanstrien Oct 30, 2026
d363fa7
chore: add httpx2 security floor
davanstrien Nov 2, 2026
0c0cc2e
test: annotate noisy logger test parameters
davanstrien Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions constraints.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
anyio>=4.14.2
cryptography>=50.0.0
filelock>=4.2.1
httpx2>=2.12.0
idna>=3.15
pydantic-settings>=2.14.2
PyJWT>=2.15.0
Expand Down
2 changes: 1 addition & 1 deletion packages/data-designer-config/src/data_designer/logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ def _make_stream_formatter() -> logging.Formatter:
return logging.Formatter(log_format, time_format)


_DEFAULT_NOISY_LOGGERS = ["httpx", "matplotlib", "mcp"]
_DEFAULT_NOISY_LOGGERS = ["httpx", "httpx2", "matplotlib", "mcp"]

@andreatnvidia andreatnvidia Oct 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we extend test_configure_logging_silences_default_noisy_loggers to cover httpx2 too? Parametrizing it over httpx and httpx2, and resetting each logger’s level before configuring logging, would protect against regressions and test-order effects. Non-blocking suggestion.

@davanstrien davanstrien Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in d363fa7, with type annotations added in 0c0cc2e.


LOG_INDENT = " |-- "
LOG_DOUBLE_INDENT = " | |-- "
Expand Down
15 changes: 8 additions & 7 deletions packages/data-designer-config/tests/test_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,15 +285,16 @@ def test_quiet_noisy_logger():
assert len(logger.handlers) == 0


def test_configure_logging_silences_default_noisy_loggers(stub_default_logging_config):
config = stub_default_logging_config
configure_logging(config)
@pytest.mark.parametrize("logger_name", ["httpx", "httpx2", "matplotlib"])
def test_configure_logging_silences_default_noisy_loggers(
stub_default_logging_config: LoggingConfig, logger_name: str
) -> None:
noisy_logger = logging.getLogger(logger_name)
noisy_logger.setLevel(logging.NOTSET)

httpx_logger = logging.getLogger("httpx")
matplotlib_logger = logging.getLogger("matplotlib")
configure_logging(stub_default_logging_config)

assert httpx_logger.level == logging.WARNING
assert matplotlib_logger.level == logging.WARNING
assert noisy_logger.level == logging.WARNING


@pytest.mark.parametrize(
Expand Down
2 changes: 1 addition & 1 deletion packages/data-designer-engine/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ dependencies = [
"fsspec>=2026.6.0,<2027", # 2026.6.0 fixes CVE-2026-104851
"httpx>=0.27.2,<1",
"httpx-retries>=0.4.2,<1",
"huggingface-hub>=1.0.1,<2",
"huggingface-hub>=1.0.1,<3",
"jinja2>=3.1.6,<4",
"json-repair>=0.60.1,<1",
"jsonpath-rust-bindings>=1.0,<2",
Expand Down
2 changes: 1 addition & 1 deletion packages/data-designer/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ path = "dev-tools/hatch_build.py"
dependencies = [
"data-designer-config=={{ version }}",
"data-designer-engine=={{ version }}",
"huggingface-hub>=1.0.1,<2",
"huggingface-hub>=1.0.1,<3",
"opentelemetry-api>=1.45.1,<1.46",
"opentelemetry-exporter-prometheus>=0.66b1,<0.67",
"opentelemetry-sdk>=1.45.1,<1.46",
Expand Down
4 changes: 3 additions & 1 deletion packages/data-designer/tests/cli/test_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,9 @@ def test_app_rejects_unknown_options_before_script_separator(mock_controller_cls
)

assert result.exit_code == 2
assert "No such option: --num-recrods" in click.unstyle(result.output)
output = click.unstyle(result.output)
assert "No such option" in output
assert "--num-recrods" in output
mock_controller_cls.assert_not_called()


Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ constraint-dependencies = [
"anyio>=4.14.2",
"cryptography>=50.0.0",
"filelock>=4.2.1",
"httpx2>=2.12.0",
"idna>=3.15",
"pydantic-settings>=2.14.2",
"PyJWT>=2.15.0",
Expand Down
1 change: 1 addition & 0 deletions tests_e2e/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ constraint-dependencies = [
"anyio>=4.14.2",
"cryptography>=50.0.0",
"filelock>=4.2.1",
"httpx2>=2.12.0",
"idna>=3.15",
"pydantic-settings>=2.14.2",
"PyJWT>=2.15.0",
Expand Down
131 changes: 85 additions & 46 deletions uv.lock
View file
Open in desktop

Large diffs are not rendered by default.

Loading