Repository navigation
chore: reduce release tooling dependencies - #1124
Conversation
Restore the previous Graphify version and use nbclient for notebook execution. Remove the Jupyter frontend and nbconvert dependency stack while retaining security constraints, audits and isolated tooling setup. Signed-off-by: Andre Manoel <amanoel@nvidia.com>
|
Fern preview: https://nvidia-preview-pr-1124.docs.buildwithfern.com/nemo/datadesigner
|
[Medium impact] The changes since the last review appear safe to merge. SummaryReduces release-tool dependencies while keeping notebook execution and structural analysis.
|
svcnvidia-nemo-ci
left a comment
There was a problem hiding this comment.
No confirmed Critical or Warning findings.
Reviewed all 14 changed files and directly affected paths, including Graphify baseline compatibility, notebook conversion/execution and failure cleanup, dependency/lock/constraint alignment, and consumers of the removed CSS tooling.
Validation was static source review only. No tests, notebook executions, dependency installations, or audits were run. Third-party CLI implementations were unavailable for direct inspection.
Note: formal approval is not available for this request, so this review is posted as a comment only.
Review generated by codex. This was a full review. Request a full review with /review reset=true.
nabinchha
left a comment
There was a problem hiding this comment.
Thanks for putting this together, @andreatnvidia!
Summary
The implementation matches the stated goal: it reduces release tooling dependencies by restoring Graphify 0.4.23 and using Jupytext plus nbclient for notebook execution. The workspace lock removes 44 packages without adding packages or changing retained package versions.
Findings
No actionable findings in commit c593de234174f0d0d0fa6683e2c6e1e5a04db44e.
What Looks Good
- Graphify compatibility tests cover baseline resets, graph replacement after source deletion, and baseline preservation on export failure.
- Notebook retries remove failed outputs and update the cache only after successful execution.
- Both Make pipelines preserve notebook working directories and save executed outputs; a second cached build reuses the notebook successfully.
Residual Risk
Validation included 10 Graphify tests, 4 notebook build tests, synthetic execution through both Make pipelines, cache reuse, Ruff lint/format checks, and shell syntax checks. Synthetic execution used nbclient 0.10.4 with independently installed notebook tools rather than the complete locked workspace. Full package suites, live model-provider notebooks, and dependency vulnerability audits were not rerun.
Verdict
Ship it — no confirmed issues found.
This review was generated by an AI assistant.
Keep existing widget support for notebook progress output, preserve saved graphs on partial export failures, and hold Graphify at its supported API. Retain compatibility with older notebook build refs and tool overrides. Signed-off-by: Andre Manoel <amanoel@nvidia.com>
Limit the Graphify hold to routine version updates while the structural adapter targets the 0.4 API. Signed-off-by: Andre Manoel <amanoel@nvidia.com>
Summary
Reduce notebook and structural-analysis dependencies for the upcoming release. Restore Graphify 0.4.23 and execute notebooks with nbclient, removing the Jupyter frontend and nbconvert stack from the workspace.
Related Issue
Follow-up to #1027 and #1093.
Changes
Testing
Checklist