[PyTorch][Test-Fix] Scale test_multi_process_ep outer timeout with launcher pass count - #3415
Open
phu0ngng wants to merge 2 commits into
Open
[PyTorch][Test-Fix] Scale test_multi_process_ep outer timeout with launcher pass count#3415phu0ngng wants to merge 2 commits into
phu0ngng wants to merge 2 commits into
Conversation
…s count Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Collaborator
Author
|
/te-ci L1 pytorch |
Contributor
Greptile SummaryThe PR scales the PyTorch expert-parallel test’s outer subprocess timeout with the number of launcher passes while preserving the configured timeout for each individual pass.
Confidence Score: 5/5The PR appears safe to merge because the pass counter exactly matches the launcher’s current sequential pass invocations and the revised timeout preserves each pass’s existing budget. The changed timeout calculation correctly allocates one configured timeout interval to each of the seven current launcher passes and adds a fixed allowance for launcher overhead. Important Files Changed
Reviews (1): Last reviewed commit: "Merge branch 'main' into fix/ep-test-out..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: