Skip to content

[PyTorch][Test-Fix] Scale test_multi_process_ep outer timeout with launcher pass count - #3415

Open
phu0ngng wants to merge 2 commits into
NVIDIA:mainfrom
phu0ngng:fix/ep-test-outer-timeout
Open

[PyTorch][Test-Fix] Scale test_multi_process_ep outer timeout with launcher pass count#3415
phu0ngng wants to merge 2 commits into
NVIDIA:mainfrom
phu0ngng:fix/ep-test-outer-timeout

Conversation

@phu0ngng

Copy link
Copy Markdown
Collaborator

Description

Please include a brief summary of the changes, relevant motivation and context.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

…s count

Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
@phu0ngng

Copy link
Copy Markdown
Collaborator Author

/te-ci L1 pytorch

@greptile-apps

greptile-apps Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR scales the PyTorch expert-parallel test’s outer subprocess timeout with the number of launcher passes while preserving the configured timeout for each individual pass.

  • Adds a helper that counts the launcher's seven current run_pass invocations.
  • Computes the outer timeout as the aggregate per-pass budget plus 60 seconds of overhead.
  • Continues forwarding NVTE_TEST_EP_TIMEOUT_S to each launcher pass through TEST_TIMEOUT_S.

Confidence Score: 5/5

The PR appears safe to merge because the pass counter exactly matches the launcher’s current sequential pass invocations and the revised timeout preserves each pass’s existing budget.

The changed timeout calculation correctly allocates one configured timeout interval to each of the seven current launcher passes and adds a fixed allowance for launcher overhead.

Important Files Changed

Filename Overview
tests/pytorch/distributed/test_ep.py Counts the current launcher passes and scales the parent subprocess timeout accordingly; no actionable defect was identified.

Reviews (1): Last reviewed commit: "Merge branch 'main' into fix/ep-test-out..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant