Skip to content

Fix include after ptx move - #3416

Merged
ptrendx merged 1 commit into
NVIDIA:mainfrom
mmarcinkiewicz:patch-1
Aug 22, 2026
Merged

Fix include after ptx move#3416
ptrendx merged 1 commit into
NVIDIA:mainfrom
mmarcinkiewicz:patch-1

Conversation

@mmarcinkiewicz

@mmarcinkiewicz mmarcinkiewicz commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Description

Please include a brief summary of the changes, relevant motivation and context.

Because:

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Fix include ptx_arch_spec.cuh in transformer_engine/common/cast/fused_group_requantize.cu

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Michał Marcinkiewicz <43240942+mmarcinkiewicz@users.noreply.github.com>
@github-actions github-actions Bot added the community-contribution PRs from external contributor outside the core maintainers, representing community-driven work. label Aug 22, 2026
@greptile-apps

greptile-apps Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes compilation of the fused grouped MXFP8 requantization source after an architecture-specific PTX helper was moved.

  • Replaces the direct ptx.cuh include with ptx_arch_spec.cuh.
  • Preserves access to general PTX declarations through the new header’s transitive include while restoring access to float_to_e8m0.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable correctness, security, or build issues identified.

The new architecture-specific header provides the moved helper, transitively retains the previous PTX declarations, and is used by an architecture-specific CUDA compilation unit as intended.

Important Files Changed

Filename Overview
transformer_engine/common/cast/fused_group_requantize.cu Updates the PTX helper include to the intended architecture-specific header without dropping declarations from the original header.

Reviews (1): Last reviewed commit: "Fix include after ptx move" | Re-trigger Greptile

@ptrendx
ptrendx merged commit 849ad3f into NVIDIA:main Aug 22, 2026
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution PRs from external contributor outside the core maintainers, representing community-driven work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants