Repository navigation
Detect NVSHMEM static heap fallback to enable symmetric heap size hints. - #164
Merged
Merged
Conversation
Signed-off-by: Josh Romero <joshr@nvidia.com>
Signed-off-by: Josh Romero <joshr@nvidia.com>
Collaborator
Author
|
/build |
|
🚀 Build workflow triggered! View run |
Signed-off-by: Josh Romero <joshr@nvidia.com>
|
✅ Build workflow passed! View run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On platforms that do not support GDRDMA with VMM memory (e.g. NVIDIA Spark GB10), NVSHMEM will fallback to using a static symmetric heap, even if
NVSHMEM_DISABLE_CUDA_VMMis unset. However, cuDecomp's useful warning messages on allocation failures due to an incorrectly sized heap are only active when a user explicitly forces NVSHMEM to use a static heap viaNVSHMEM_DISABLE_CUDA_VMM.This PR attempts to detect systems where NVSHMEM will fallback to a static heap, based on the current implementation, to enable these useful error messages.