Repository navigation
Conversation
Require a successful Cargo run and nonempty expected PTX before accepting non-Hopper fallbacks. Preserve optional ptxas skips and tolerated PTX load failures. Add CPU-only regression coverage for the verdicts and the runner summary and exit status. Signed-off-by: Guilherme Pedroza <guilhermebarb0sa@proton.me>
Contributor
Author
|
Local validation: |
Contributor
Author
|
WGMMA smoketest passed on NVIDIA GeForce RTX 5060 Ti (sm_120).
This validates the non-Hopper PTX fallback and ptxas assembly. |
Contributor
Author
|
I forgot the contribution PRs were paused, I'm sorry. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The WGMMA PTX fallback could report PASS after a failed Cargo run or when the expected PTX was missing or empty. Require a successful run and a nonempty artifact before accepting the fallback.
Fixes #1414
Changes
Testing
bash cuda-oxide/scripts/check-example-smoketest-contract.shpassed:Bash syntax, SPDX headers, and
git diff --checkalso passed. In temporary copies, the tests rejected the original bug and removal of either new check.just -f cuda-oxide/Justfile checkpassescargo oxide run wgmmaor GPU smoketest passes