Repository navigation
[FEA] Add peak memory tracking to join nvbenchmarks - #24781
Closed
GregoryKimball wants to merge 3 commits into
Closed
GregoryKimball wants to merge 3 commits into
GregoryKimball wants to merge 3 commits into
Conversation
Move the memory_stats_logger implementation out of memory_stats.hpp into memory_stats.cpp (PIMPL) so the header no longer pulls in rmm/mr/statistics_resource_adaptor.hpp, and report peak_memory_usage from all join nvbench benchmarks, including the .cu ones. Part of NVIDIA#10528
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
@PointKernel would you please take this over? |
Member
|
We can close this as I've opened #24731 to address the same issue. |
Member
|
superseded by #24731 |
Contributor
Author
|
Thank you for being way ahead of me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #10528
Add peak memory tracking to join nvbenchmarks. #22548 omitted
join.cumicrobenchmark.Checklist