pyxis: fix include path so <slurm/spank.h> resolves with a custom slurm_install_prefix - #1388
Open
100milliongold wants to merge 1 commit into
Open
pyxis: fix include path so <slurm/spank.h> resolves with a custom slurm_install_prefix#1388100milliongold wants to merge 1 commit into
100milliongold wants to merge 1 commit into
Conversation
…rm_install_prefix
The build task passed -I {{ slurm_install_prefix }}/include/slurm, but
pyxis sources include <slurm/spank.h>, so the compiler looked for
.../include/slurm/slurm/spank.h. With the default prefix (/usr/local)
this went unnoticed because /usr/local/include is on the compiler's
default search path. With any other prefix the build fails:
pyxis_dispatch.c:5:10: fatal error: slurm/spank.h: No such file or directory
Pass -I {{ slurm_install_prefix }}/include instead.
Observed on DGX OS 7.5.0 with slurm_install_prefix=/raid/slurm/usr/local
(DeepOps master, Slurm 26.05.3, pyxis 0.11.1). After the change the
pyxis build completes.
Signed-off-by: Jea-Eok-Kim <je.kim@xiilab.com>
100milliongold
marked this pull request as ready for review
September 3, 2026 13:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
roles/pyxis/tasks/pyxis.ymlpasses-I {{ slurm_install_prefix }}/include/slurmto the pyxis build, but pyxis sources#include <slurm/spank.h>, so the compiler looks for.../include/slurm/slurm/spank.h. With the default prefix (/usr/local) this is masked because/usr/local/includeis already on the compiler's default search path. With any other prefix the build fails:Reproduced on DGX OS 7.5.0 with
slurm_install_prefix: /raid/slurm/usr/local(DeepOps master, Slurm 26.05.3, pyxis 0.11.1).Fix
Pass
-I {{ slurm_install_prefix }}/includeinstead. One-line change; behaviour with the default prefix is unchanged.Verification
After the change,
make -jin/usr/local/src/pyxiscompletes and the slurm-cluster playbook proceeds past the pyxis role on the system above.