nvidia_dcgm: do not replace the DCGM that DGX OS already ships - #1394
Open
100-JM wants to merge 1 commit into
Open
nvidia_dcgm: do not replace the DCGM that DGX OS already ships#1394100-JM wants to merge 1 commit into
100-JM wants to merge 1 commit into
Conversation
On DGX systems install-dgx.yml unconditionally installs the unversioned datacenter-gpu-manager package, which the CUDA repo resolves to DCGM 3.3.9. DGX OS 7.x ships datacenter-gpu-manager-4-cuda13 (4.5.2). The two series conflict, so apt removes the 4.x packages and installs 3.3.9. The play reports ok and nothing stops; the regression only shows up later: dcgmi diag fails with "Detected unsupported Cuda version" (3.3.9 has no CUDA 13 plugin) and dcgmi discovery -l reports 0 NvSwitches on a DGX B300 that has two. The Ubuntu branch already honours dcgm_pkg_name; only the DGX branch hardcodes the name. roles/nvidia-dgx/vars/ubuntu-24.04.yml lists datacenter-gpu-manager-4-cuda13 for DGX OS 7, so the two roles disagree. Skip the install on DGX when any datacenter-gpu-manager package is already present, and use dcgm_pkg_name otherwise. Observed on DGX B300, DGX OS 7.5.0, driver 580.126.20. Signed-off-by: 백지명 <wlaud9805@gmail.com>
100-JM
marked this pull request as ready for review
September 4, 2026 02:32
dholt
requested changes
Sep 4, 2026
dholt
left a comment
Contributor
There was a problem hiding this comment.
Please make the DGX task validate the specific acceptable DCGM package/version rather than treating any datacenter-gpu-manager* package as sufficient. Handle at least the existing legacy 3.x state, partial package sets, and the fully absent state so each converges to the correct DGX OS package; also ensure the absent-state package name is explicitly DGX-compatible instead of relying on the current unversioned default.
Automated triage review (agent-generated on the maintainer's behalf; a human maintainer decides merges).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
roles/nvidia_dcgm/tasks/install-dgx.ymlinstalls the unversioneddatacenter-gpu-managerpackage on every DGX. In the CUDA apt repo that name resolves to DCGM 3.3.9. DGX OS 7.x already shipsdatacenter-gpu-manager-4-cuda13(4.5.2). The two series conflict, so apt removes the 4.x packages and installs 3.3.9. The task reportsok, so nothing in the play fails.The regression is only visible afterwards on the node:
The Ubuntu branch (
install-ubuntu.yml) already uses{{ dcgm_pkg_name }}; only the DGX branch hardcodes the name.roles/nvidia-dgx/vars/ubuntu-24.04.ymllistsdatacenter-gpu-manager-4-cuda13for DGX OS 7, so the two roles currently disagree.Reproduced on DGX B300, DGX OS 7.5.0, driver 580.126.20,
install_dcgm: true(default) viaplaybooks/slurm-cluster.yml.Fix
On DGX, gather package facts and skip the install when any
datacenter-gpu-manager*package is already present (DGX OS provides it). When nothing is present, install{{ dcgm_pkg_name }}like the Ubuntu branch does. Non-DGX branches are unchanged.Verification
Restored the DGX OS version on the node (
apt-get install datacenter-gpu-manager-4-cuda13=1:4.5.2-1 datacenter-gpu-manager-4-core=1:4.5.2-1):Fabric Manager logs show the same two switches with 74 active links each. With the patched task, a re-run of
slurm-cluster.ymlleaves the 4.5.2 packages in place.