chore(internals): cover playground url construction in utils - #314
Merged
Merged
Conversation
Adds unit tests that load playground utils with ELEMENTS_PLAYGROUND_BASE_URL set, covering name/theme/referer query construction and the url length limit. Signed-off-by: Cursor Agent <cursoragent@cursor.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
coryrylan
approved these changes
Sep 17, 2026
Collaborator
|
🎉 This issue has been resolved in version 2.1.0 🎉 |
Collaborator
|
🎉 This issue has been resolved in version 2.8.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selected task
coverage for
projects/internals/tools/src/playground/utils.ts.Selector rationale: "5 uncovered lines, 93.42% lines and 81.81% branches, the smallest gap below the 90% threshold".
Measurement
Added tests in the existing
utils.test.tsthat reload the module withELEMENTS_PLAYGROUND_BASE_URLset socreatePlaygroundURLactually builds a URL. They cover optionalname/theme/refererquery params and the character-limitToolError.Public API
No public API changed. Production
utils.tsis untouched.Left alone
serialize(..., compress = false)branch, which is not reachable from the public surface.Validation
projects/internals/tools:lintpass;test734 pass.test:types,test:axe,test:ssr,test:lighthouse,test:visual: not defined for this package.mise exec -- pnpm run ci: pass.git diff --check: pass.