Skip to content

chore(ci): update pnpm and nodejs - #315

Merged
coryrylan merged 1 commit into
mainfrom
topic-update-deps
Sep 17, 2026
Merged

coryrylan merged 1 commit into
mainfrom
topic-update-deps

Conversation

@coryrylan

@coryrylan coryrylan commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores

    • Updated the supported Node.js runtime to 26.8.2.
    • Updated pnpm to 12.4.2.
    • Updated the bundled adm-zip dependency to 0.6.1.
    • Standardized dependency version management across workspace projects.
  • Documentation

    • Refreshed environment setup guidance to use managed tool versions.
    • Updated troubleshooting instructions to verify Node.js using project configuration rather than a hard-coded version.

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 29e4becc-cf96-464f-a9ee-138b287b2832

📥 Commits

Reviewing files that changed from the base of the PR and between f5b35ac and 840edf4.

⛔ Files ignored due to path filters (2)
  • mise.lock is excluded by !**/*.lock
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (10)
  • .nvmrc
  • AGENTS.md
  • NOTICE.md
  • mise.toml
  • package.json
  • pnpm-workspace.yaml
  • projects/cli/NOTICE.md
  • projects/cli/package.json
  • projects/internals/tools/package.json
  • projects/site/src/docs/internal/guidelines/troubleshooting.md

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Configuration and dependency updates

Layer / File(s) Summary
Toolchain version alignment
.nvmrc, mise.toml, package.json, AGENTS.md, projects/site/src/docs/internal/guidelines/troubleshooting.md
Node.js and pnpm versions are updated to 26.8.2 and 12.4.2. Guidance now refers to repository-managed tool versions.
adm-zip catalog and notices
pnpm-workspace.yaml, projects/cli/package.json, projects/internals/tools/package.json, NOTICE.md, projects/cli/NOTICE.md
adm-zip is configured as catalog version 0.6.1, package manifests use the catalog reference, and notices report version 0.6.1.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: cursoragent

Merge Risk: ⚪ Minimal · up to 840ed

No concrete current-head risk is identified; the metadata and documented versions are aligned.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary Node.js and pnpm version updates. It does not mention the secondary adm-zip update, but the title does not need to cover every change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Warning

Some tools did not complete. Review the errors below.

🔧 Vale (3.19.0)

{
"Line": 0,
"Path": "",
"Text": "E100 [loadStyles] Runtime error\n\nstyle 'Google' does not exist on StylesPath\n\nExecution stopped with code 1.",
"Code": "E100",
"Span": 0
}


Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Cory Rylan <crylan@nvidia.com>
@coryrylan
coryrylan merged commit 6eb2c4b into main Sep 17, 2026
15 checks passed
@coryrylan
coryrylan deleted the topic-update-deps branch September 17, 2026 19:38
@coryrylan

Copy link
Copy Markdown
Collaborator Author

🎉 This issue has been resolved in version 2.1.0 🎉

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants