Skip to content

chore(internals): cover skill validation error paths - #317

Merged
coryrylan merged 1 commit into
mainfrom
topic/upkeep/coverage/skills-utils
Sep 18, 2026
Merged

coryrylan merged 1 commit into
mainfrom
topic/upkeep/coverage/skills-utils

Conversation

@cursor

@cursor cursor Bot commented Sep 18, 2026

Copy link
Copy Markdown

Selected task

Coverage for projects/internals/tools/src/skills/utils.ts.

Selector rationale: "5 uncovered lines, 94.18% lines and 81.39% branches, the smallest gap below the 90% threshold".

Measurement

Lines Branches
Before 81/86 (94.18%) 35/43 (81.39%)
After 86/86 (100%) 43/43 (100%)

Added unit tests in utils.test.ts for the public validation surface: directory basename mismatch, empty title, empty files, non-string file content, frontmatter/registry mismatch, and the default skills registry argument.

Public API

No public API changed. Production code is unmodified.

Left alone

  • No production edits, including leaving the typeof content !== 'string' runtime check in place (it is now covered rather than deleted).
  • Did not touch visual baselines, other packages, or ESLint suppressions.

Validation

  • projects/internals/tools: lint pass, test pass (741 tests), test:coverage pass
  • test:types, test:axe, test:ssr, test:lighthouse, test:visual: not defined for this package
  • Root pnpm run ci pass
Open in Web View Automation 

@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: cd51dd78-0fef-407a-a66a-2afe63724a13

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@coryrylan coryrylan added the upkeep label Sep 18, 2026 — with Cursor
@cursor
cursor Bot marked this pull request as ready for review September 18, 2026 06:27
@coryrylan
coryrylan force-pushed the topic/upkeep/coverage/skills-utils branch from 74f9211 to 53edcd5 Compare September 18, 2026 17:50
Adds unit tests for directory name, title, empty files, non-string
content, and frontmatter mismatch in skills/utils.ts, raising line
coverage from 94.18% to 100% and branch coverage from 81.39% to 100%.
No behavior change.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>
@coryrylan
coryrylan force-pushed the topic/upkeep/coverage/skills-utils branch from 53edcd5 to 5de363c Compare September 18, 2026 18:20
@coryrylan
coryrylan enabled auto-merge (rebase) September 18, 2026 18:21
@coryrylan
coryrylan merged commit 6de0a7e into main Sep 18, 2026
15 checks passed
@coryrylan
coryrylan deleted the topic/upkeep/coverage/skills-utils branch September 18, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants