chore(internals): cover skill validation error paths - #317
Merged
Merged
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
coryrylan
approved these changes
Sep 18, 2026
coryrylan
force-pushed
the
topic/upkeep/coverage/skills-utils
branch
from
September 18, 2026 17:50
74f9211 to
53edcd5
Compare
Adds unit tests for directory name, title, empty files, non-string content, and frontmatter mismatch in skills/utils.ts, raising line coverage from 94.18% to 100% and branch coverage from 81.39% to 100%. No behavior change. Signed-off-by: Cursor Agent <cursoragent@cursor.com>
coryrylan
force-pushed
the
topic/upkeep/coverage/skills-utils
branch
from
September 18, 2026 18:20
53edcd5 to
5de363c
Compare
coryrylan
enabled auto-merge (rebase)
September 18, 2026 18:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selected task
Coverage for
projects/internals/tools/src/skills/utils.ts.Selector rationale: "5 uncovered lines, 94.18% lines and 81.39% branches, the smallest gap below the 90% threshold".
Measurement
Added unit tests in
utils.test.tsfor the public validation surface: directory basename mismatch, empty title, empty files, non-string file content, frontmatter/registry mismatch, and the defaultskillsregistry argument.Public API
No public API changed. Production code is unmodified.
Left alone
typeof content !== 'string'runtime check in place (it is now covered rather than deleted).Validation
projects/internals/tools:lintpass,testpass (741 tests),test:coveragepasstest:types,test:axe,test:ssr,test:lighthouse,test:visual: not defined for this packagepnpm run cipass