Repository navigation
Remove package-lock.json and enforce a single pnpm lockfile - #1029
Open
Godfrey-Delight wants to merge 3 commits into
Open
Godfrey-Delight wants to merge 3 commits into
Godfrey-Delight wants to merge 3 commits into
Conversation
Removes the committed package-lock.json, adds it plus npm-shrinkwrap.json, yarn.lock, and bun.lockb to .gitignore, and extends scripts/validate-package-manager.mjs to fail with an actionable message whenever a non-pnpm lockfile is present, alongside aligning the supported Node range to 22–26. Wires pnpm run check:package-manager into the CI lint job so PRs introducing a forbidden lockfile fail immediately, replaces npm run/npm ci with pnpm run/pnpm install --frozen-lockfile in ci.yml and release.yml, and updates generate-sbom.mjs and docs/RELEASE_SBOM.md to require pnpm-lock.yaml exclusively. Converts README.md and docs/contributing.md to consistent pnpm commands, and adds docs/MIGRATION.md notes on the lockfile consolidation. Adds 6 unit tests in tests/unit/packageManager.test.js covering standard resolution, Node version boundaries (22 and 26), and failure cases for forbidden lockfiles, unsupported package managers, and unsupported Node versions. Closes Nanle-code#962
|
@Godfrey-Delight is attempting to deploy a commit to the nanle-code's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Godfrey-Delight Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
@Godfrey-Delight reslove conflicts |
…shboard into chore/962-enforce-single-pnpm-lockfile
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the committed package-lock.json, adds it plus npm-shrinkwrap.json, yarn.lock, and bun.lockb to .gitignore, and extends scripts/validate-package-manager.mjs to fail with an actionable message whenever a non-pnpm lockfile is present, alongside aligning the supported Node range to 22–26. Wires pnpm run check:package-manager into the CI lint job so PRs introducing a forbidden lockfile fail immediately, replaces npm run/npm ci with pnpm run/pnpm install --frozen-lockfile in ci.yml and release.yml, and updates generate-sbom.mjs and docs/RELEASE_SBOM.md to require pnpm-lock.yaml exclusively. Converts README.md and docs/contributing.md to consistent pnpm commands, and adds docs/MIGRATION.md notes on the lockfile consolidation. Adds 6 unit tests in tests/unit/packageManager.test.js covering standard resolution, Node version boundaries (22 and 26), and failure cases for forbidden lockfiles, unsupported package managers, and unsupported Node versions.
Closes #962