Repository navigation
feat: extract shared core package for web and mobile (#1006) - #1129
Merged
Merged
Conversation
- Create packages/core workspace package with platform-agnostic Stellar logic - Network config, validation, formatters, addresses, reserves, operation labels, services - Comprehensive test suite covering primary flow, boundary cases, failure cases - ESLint rules enforcing no DOM/React Native imports in core - Update mobile app to import from @stellar-dev-dashboard/core - Update web app to delegate to core package - Remove duplicated code from mobile/services/stellar.ts - Add core package to pnpm-workspace.yaml - Update documentation: packages/core/README.md, root README.md, CHANGELOG.md
|
@VeronicDev is attempting to deploy a commit to the nanle-code's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
Kindly merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1006
Summary
Extract platform-agnostic Stellar logic into a shared @stellar-dev-dashboard/core\ workspace package to eliminate duplicated code between the web app (\src/lib/stellar/) and mobile app (\mobile/src/services/stellar.ts).
Changes
New Package: \packages/core/\
etworks.ts): \NETWORKS, \getServer, \getSorobanServer, \updateCustomNetworkConfig\
eserves.ts): Account reserve calculations with \AccountReserves\ type
Test Suite (_tests_/)
Lint Enforcement
o-restricted-imports\ blocking React, React Native, browser globals (\window, \document, \localStorage, etc.)
Consumer Updates
eserves.ts, \�alidation.ts\ now delegate to core
Workspace Config
Documentation
Acceptance Criteria Met