Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WebUI API accepts anonymous remote requests to data, logs, environment information, and crawler controls; WebSocket handshakes have no origin/authentication boundary. Add shared ASGI access middleware and bind the default entry point to loopback with proxy-header parsing disabled.
Without a token, require a loopback peer/Host and a trusted browser Origin. With MEDIACRAWLER_API_TOKEN configured, require Bearer authorization for every HTTP request and WebSocket handshake, including local clients. Preserve local WebUI and Vite development origins. Remote deployments and the current WebUI token-input limitation are documented in docs/api-access.md.
Validation: all 12 new access-control tests fail before the fix. The isolated upstream branch passes all 108 tests (Python 3.11, Windows with PYTHONUTF8=1). Tests verify sensitive HTTP routes, blocked start/stop side effects, malformed/rebound Host, same/cross-origin requests, valid local WebSocket connections, and correct/incorrect tokens. Existing API parameter tests use a fixture-only token and continue to run.
Cookie process transport and JSONL support are separate PRs. Fork tracking and CI: PR #23. Related report: saksim#1.