Repository navigation
docs(react-native): rewrite README - #90
Open
NathanWalker wants to merge 6 commits into
Open
NathanWalker wants to merge 6 commits into
NathanWalker wants to merge 6 commits into
Conversation
Put requirements and installation first and move the monorepo build
scripts to a closing section. Document that iOS JS-thread globals are
opt-in via init("", { globals: true }), Android release metadata
filtering, and the Android steps of configure and the Expo plugin.
Fix examples that touched UIKit or undefined names off the UI runtime.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Squash merge this PR as one docs commit:
docs(react-native): rewrite README.Split out of #77. All README changes from #77 are here instead of in the fix PRs, so the fix PRs don't conflict with each other in the README. Merge this last. It documents behaviour from the PRs below.
Summary
The Android main-thread / view content from #77 (
runOnUI,nativeViewHandle,androidContext,NativeScriptUIViewon Android) is left out. The Threads section still says those helpers are iOS only.Evidence
Docs only, no code changes.
Merge Danger
Door: two-way
Blast Radius: docs
If merged before #82, #83, #86, #87, #88 or #89, the README describes behaviour that isn't on the branch yet.