fix: a new finding on a line that already carries a comment is no longer dropped as a resend - #114
Merged
Merged
Conversation
…ger dropped as a resend Whether a finding is already on the pull request was decided by its position: path, line and side, ignoring the wording. A line collects comments over rounds, so an earlier remark there — resolved, or another reviewer's — silently swallowed any new finding on that line. Two findings vanished that way. Identity decides it now. `comment_threads.submitted_at` already records what diffity sent, and the page has been reading it all along to mark a row *already on the pull request*; the submit path was the one still guessing from position. Where there is no local record — a finding imported from a bundle, or posted from another machine — the same wording in the same place from the same account is the evidence left, so the author's login now comes back with the existing comments. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w
… already Self-review found the record too narrow. Pulling comments records the forge comment a thread exists as, in `github_comment_id`, and never sets `submitted_at` — so a pulled comment, which the dialog offers like any other, would have gone back out as a second copy once edited locally or shifted by a new head. The old position rule hid that. `threadsOnTheForge` answers what the name says now: sent from here, or pulled from there. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Posting a review dropped two findings as "already on the PR". They were not: the lines carried older comments, resolved in an earlier round.
isAlreadyCommentedmatched on path, line and side alone, against every inline comment on the pull request from anyone. So any comment sitting on a line made a new finding there look like a resend, andcreateReviewcounted it inskippedand said nothing.What changed
comment_threads.submitted_atalready records what diffity sent, and the page has been reading it to mark a row already on the pull request — the submit path was the one still guessing. A finding that went out once is still held back however it reads now, since the forge cannot update the comment already there.getCommentstherefore returnslogin.viewerLogin.Tests
comment-targets.test.ts— the reported case, the reworded resend, another reviewer's identical wording, CRLF.create-review-dedup.test.ts(new) — end to end through/api/github/create-reviewwith a gh that reports what is already on the pull request and keeps the review it is handed, so the assertions are about what actually went out. Two of its cases fail on the old code.0.10.36.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w