Repository navigation
Conversation
Collaborator
|
I agree that commercial adds are annoying. However, that is a not a good argument to stop updating the dependency and pin the module to an older version. |
Contributor
Author
|
@Hugo-ter-Doest There's no functional difference between the pin and the latest version other than the AD, but you merged the other PR so it's at least fixed for users who don't use storage modules. Is there another solution you'd prefer? |
Collaborator
|
No, there is no other solution I prefer. I will leave it as it is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #773.
That PR lazy-loads storage plugins so users who don't use storage avoid both the unnecessary imports and the dotenv advertising. This PR covers users who do use storage and still don't want the log spam.
Pins dotenv to
^16.4.7(latest v16) which has the same.config()API without the logging. All 858 specs pass.It might also be worth considering removing the dotenv dependency down the road and letting applications handle their own
.envloading.