Skip to content

Avoid duplicate TF-IDF spec assertions - #796

Merged
Hugo-ter-Doest merged 2 commits into
masterfrom
copilot/fix-lint-code-base
Oct 25, 2026
Merged

Hugo-ter-Doest merged 2 commits into
masterfrom
copilot/fix-lint-code-base

Conversation

Copilot AI commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

The “Lint Code Base” job failed because jscpd detected duplicate assertion logic in the TF-IDF spec.

  • Change: Extracted the repeated key check into expectTfidf, used by both the node and ruby callbacks.
expectTfidf(measure, k, 'node')
expectTfidf(measure, k, 'ruby')

Co-authored-by: Hugo-ter-Doest <7829083+Hugo-ter-Doest@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job Lint Code Base Avoid duplicate TF-IDF spec assertions Oct 25, 2026
Copilot AI requested a review from Hugo-ter-Doest October 25, 2026 10:56
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 40186777807

Coverage increased (+0.006%) to 87.218%

Details

  • Coverage increased (+0.006%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 1 coverage regression across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
lib/natural/brill_pos_tagger/lib/Brill_POS_Trainer.js 1 63.91%

Coverage Stats

Coverage Status
Relevant Lines: 9994
Covered Lines: 9024
Line Coverage: 90.29%
Relevant Branches: 3071
Covered Branches: 2371
Branch Coverage: 77.21%
Branches in Coverage %: Yes
Coverage Strength: 12923.7 hits per line

💛 - Coveralls

@Hugo-ter-Doest
Hugo-ter-Doest marked this pull request as ready for review October 25, 2026 11:08
@Hugo-ter-Doest
Hugo-ter-Doest merged commit bb8b633 into master Oct 25, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants