Repository navigation
Fix medication history update and add medicationDate to API response - #122
Merged
Merged
Conversation
- Fix UpdateMedicationHistoryRequest to use MedicationDate::forStringTime() instead of direct constructor (TypeError: int expected, string given) - Add medication_date to EloquentRepository::update() (was saving only amount and note) - Add medicationDate field to MedicationHistoryDetail DTO and OpenAPI spec - Add BaseTime ISO string conversion in BaseResponder::objectToArray() (BaseTime subclasses were serialized as UNIX timestamps instead of ISO strings) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateMedicationHistoryRequestto useMedicationDate::forStringTime()instead of direct constructor (TypeError: int expected, string given)medication_datetoEloquentRepository::update()(was saving only amount and note)medicationDatefield toMedicationHistoryDetailDTO and OpenAPI specBaseTimeISO string conversion inBaseResponder::objectToArray()(BaseTime subclasses were serialized as UNIX timestamps instead of ISO strings)Test plan
/api/medication_histories/{id}withmedication_datereturns updated valuemedicationDatefield appears in API response as ISO 8601 string🤖 Generated with Claude Code