Repository navigation
Live Radar HUD + donor-contract into nap-dev - #24
Merged
Merged
Conversation
Wire card to persist F190 and add a Settings override. Leave the VIN blank and a working radar stays on this-car passthrough. Co-authored-by: Cursor <cursoragent@cursor.com>
Device checkout smudges every LFS file, including unused x86_64 acados. Process replay rebuilt those blobs onto hashes that are not on comma's GitLab LFS, so installer and updater 404. Point them back at the nap-release objects. Co-authored-by: Cursor <cursoragent@cursor.com>
Testers need a one-shot F190 read without a VIN fault, and the radar controls were crowding the main NAP page. Nested under Radar Settings on 3X and C4. Co-authored-by: Cursor <cursoragent@cursor.com>
Position is only Donor Position on 0x560 now, including empty VIN. Read VIN shows whether F190 stuck instead of sitting on Read. Co-authored-by: Cursor <cursoragent@cursor.com>
Stop forcing 4WD on this RWD car when a saved VIN has character 8 of 2.
Bump opendbc so ignore also covers the leftover freeze+SGUFail lockout and reads NAPRadarIgnoreHwFail live from disk if params_pyx misses it.
Bump opendbc so IgnoreHwFail no longer lets frozen SGUFail tracks become leadOne and slam aTarget.
Bump opendbc so Ignore keeps engage and drops frozen SGUFail ghosts instead of setting radarFault.
… clears xwdValidity
Calibrate/test used to spawn run_script.py, which takes over the display and stops pandad. Tinkla C2 already watched cereal can without doing that. Live Radar is a push_widget overlay; Radar HUD draws the same status on the driving view. Both work onroad and close without a reboot.
Matches the new silent-until-0x560-complete gate so a cold key-on is visible on the HUD instead of looking like a dead radar.
C4 536x240 was using tici Button type (60px) and a 560x280 HUD rect. Use NAP chips, compact 16px buttons, and a HUD that never exceeds the screen.
C4 536x240 modal keeps full Close/Align and the 2B9/F190/chassis VIN compare. On-road HUD scales to fit 536x240. Decoder tests unchanged.
3X shows LIVE/FROZEN/REJECT/FAULT, SGUFail/HWFail, talking/waiting, VIN/XWD/POS/RACK, 2WD/4WD pos EPAS, 2B9 vs F190 vs chassis, and raw/age vs liveTracks. C4 is a cut-down strip: state plus one or two reject/table bits and a full Close. No Align, no VIN dump, no table. Close is pop_widget.
C4 536x240 must show full Close/Align glyphs and 2B9/F190/chassis. Do not strip the compact modal down to state+Close only.
3X overlay is 980x380 with colored 20/40/60/80 m rings and All tracks header-right. C4 stays state plus Close. Close is pop_widget.
3X overlay is 1100x400 with colored 20/40/60/80 m rings and All tracks header-right. C4 keeps a full-width bird-eye plot plus state/Close only. Close is pop_widget.
Keep 3X chips, colored 20/40/60/80 m rings, and All tracks top-right. C4 modal is plot + state/Close only — no Align, VIN trio, or table. Close is pop_widget.
C4 536x240 modal shows ID/dRel/yRel/vRel next to the plot. Chips stay state plus one or two bits and Close. Hidpi keeps 980x380, rings, All tracks header-right, and the VIN trio. Close is pop_widget.
C4 keeps minimal chips plus Close. Hidpi overlay is 1200x400 with colored 20/40/60/80 m rings and the ID/dRel/yRel/vRel table top-right. Close is still pop_widget.
Do not regress the 3X card size. C4 tracks table is unchanged.
C3X HUD is 640x340 at (x+24, y+h-20). Rings 20/40/60/80 m hidpi only. All tracks sits top-right. C4 layout untouched. Close is pop_widget.
3X card must stay 980x380 with rings, All tracks, VIN trio. C4 tracks table unchanged. Close is pop_widget.
C4 is plot + state/Close only — no Align, VIN trio, or GTW table. Hidpi overlay stays 1200x400 with colored 20/40/60/80 m rings. Close is pop_widget.
Hidpi keeps 1200x400 overlay, colored 20/40/60/80 m rings, and the ID/dRel/yRel/vRel table top-right. C4 is chips + table + small plot + Close. Close is pop_widget.
This pass: bird-eye plot back on C4, chips = state + 1-2 bits + Close. No Align, no VIN trio, no tracks table. Hidpi rings and All tracks stay. Close is pop_widget.
C4 modal shows the tracks table beside a small unlabeled-ring plot. Chips stay state plus one or two bits and Close. Hidpi 980x380. Close is pop_widget.
Correction: C4 lost the tracks data table, not the plot. Keep the table plus a small plot. Hidpi overlay 1200x400, colored 20/40/60/80 m rings, table top-right. Close is pop_widget.
C4 536x240 modal keeps ID/dRel/yRel/vRel beside a small ring plot and Close. Overlay size matches the 3X card Jack signed off.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nap-dev.radar-donor-contractatd4f9fa841f40a59d26d19cf8b2708734ae2c8cea.opendbc_reposubmodule pointer at604b9c497c2c51573c67379cd1cbbe20d2d3f9e2.Notes
radar-donor-contractis not an ancestor oforigin/nap-devororigin/naponsp-devat open time.Test plan
opendbc_reposubmodule checkout matches604b9c497c2c51573c67379cd1cbbe20d2d3f9e2