fix(android): serialize EPUB navigation after initial page load - #226
Merged
Merged
Conversation
SifAa
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
goToLocatorimmediately after mounting an Android EPUB navigator could return success and then be overwritten by the navigator's initial restore, leaving the reader on the first reading-order item. Navigation now waits for the first visible page to load before applying the requested locator.The regression test reproduces the race by navigating to the second reading-order item immediately after mounting the reader and waiting for the emitted locator to settle there.
Validation:
ktlint --format,bin/format,bin/analyze, andgit diff --checkpassed.wakelock_plustest task cannot start its JUnit Platform executor;:flutter_readium:testDebugUnitTestpasses.