Skip to content

fix(cli): [SEC-15,SEC-25] harden dependency analysis - #173

Merged
tim-thacker-nullify merged 2 commits into
mainfrom
fix/sec-15-25
Nov 16, 2026
Merged

tim-thacker-nullify merged 2 commits into
mainfrom
fix/sec-15-25

Conversation

@tim-thacker-nullify

@tim-thacker-nullify tim-thacker-nullify commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Codex

Dependency analysis passed option-shaped revisions to Git and retained vulnerable indirect dependencies.

flowchart TD
    INPUT["CLI or CI revision"] --> GUARD{"ValidateGitRef: this PR"}
    GUARD -->|"Leading dash"| REFUSE["Return ErrGitRefOption"]
    GUARD -->|"Revision"| GIT["Git diff, show or rev-parse<br/>Revision and path boundaries preserved"]
Loading
  • Validate all dynamic revision operands in scan, command resolution and CI detection before launching Git; keep dash-leading filenames usable.
  • Upgrade gRPC to v1.85.0, the OTel module set to v1.47.0 and x/text to v0.44.0, with required transitive updates generated on office server 2 (OTel advisory).
  • Require Go 1.26.11 so CI and release builds use the patched standard library.
  • Add real-Git regressions for malicious operands and valid SHA, branch and ancestry revisions.

Closes SEC-15, SEC-25.

Server 2: real-Git regressions, full unit suite, build and lint pass with Go 1.26.11. govulncheck finds no called gRPC, OTel or x/text vulnerabilities; its scan still reports GO-2026-4883 and GO-2026-4887 through Docker SDK initializers. The CLI uses the Docker client and does not host a daemon or install plugins; the scan is not clean.

Estimated correctness confidence: 95%, based on independent source review and completed Linux validation; other platform builds remain unverified. Merge risk: moderate across indirect dependencies and the Go patch requirement. Release risk: Go 1.26.11 is now required; Docker scanner findings remain disclosed.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@tim-thacker-nullify tim-thacker-nullify added the patch Patch version updates (fixes) label Nov 16, 2026
@tim-thacker-nullify
tim-thacker-nullify marked this pull request as ready for review November 16, 2026 13:47
@tim-thacker-nullify
tim-thacker-nullify merged commit e1536a9 into main Nov 16, 2026
3 of 4 checks passed
@tim-thacker-nullify
tim-thacker-nullify deleted the fix/sec-15-25 branch November 16, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Patch version updates (fixes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant