Repository navigation
fix(cli): [SEC-15,SEC-25] harden dependency analysis - #173
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency analysis passed option-shaped revisions to Git and retained vulnerable indirect dependencies.
flowchart TD INPUT["CLI or CI revision"] --> GUARD{"ValidateGitRef: this PR"} GUARD -->|"Leading dash"| REFUSE["Return ErrGitRefOption"] GUARD -->|"Revision"| GIT["Git diff, show or rev-parse<br/>Revision and path boundaries preserved"]Closes SEC-15, SEC-25.
Server 2: real-Git regressions, full unit suite, build and lint pass with Go 1.26.11. govulncheck finds no called gRPC, OTel or x/text vulnerabilities; its scan still reports GO-2026-4883 and GO-2026-4887 through Docker SDK initializers. The CLI uses the Docker client and does not host a daemon or install plugins; the scan is not clean.
Estimated correctness confidence: 95%, based on independent source review and completed Linux validation; other platform builds remain unverified. Merge risk: moderate across indirect dependencies and the Go patch requirement. Release risk: Go 1.26.11 is now required; Docker scanner findings remain disclosed.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.