Repository navigation
[17.0][FIX] currency_rate_update_xe: send User-Agent and raise on HTTP error - #218
Closed
shirashi3771 wants to merge 1 commit into
Closed
shirashi3771 wants to merge 1 commit into
shirashi3771 wants to merge 1 commit into
Conversation
OCA-git-bot
added
mod:currency_rate_update_xe
shirashi3771
force-pushed
the
17.0-mig-currency_rate_update_xe
branch
from
May 19, 2026 08:33
d4d4ba0 to
5f1643e
Compare
Member
|
Please put correct commit message and module name. |
miquelpascual
approved these changes
May 19, 2026
miquelpascual
left a comment
miquelpascual
left a comment
There was a problem hiding this comment.
LGTM once you fix the commit and title
shirashi3771
changed the title
shirashi3771
force-pushed
the
17.0-mig-currency_rate_update_xe
branch
from
May 19, 2026 11:10
5f1643e to
5d47152
Compare
Author
|
Now, it's possible to merge? |
It looks good now, but I don't have permission to merge it. @pedrobaeza could you help us with that please? |
pedrobaeza
reviewed
May 19, 2026
| "GET", | ||
| url, | ||
| timeout=10, | ||
| headers={"User-Agent": "Mozilla/5.0"}, |
| # computes date_from = today - 1 day, producing one rate per day in | ||
| # the range — which is correct behaviour but makes this assertion | ||
| # depend on whether XE returns a rate for the past-day URL. | ||
| self.xe_provider.last_successful_run = self.today - relativedelta(days=1) |
Member
There was a problem hiding this comment.
Instead of this, you can freeze the time for the tests.
This was referenced Jun 20, 2026
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
Member
|
Related #242 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #216 .
@mpascuall , @lbarry-apsl , @peluko00, @javierobcn, @BernatObrador , @cubells , @isugac, @palomagrc93, @LlucSG, @ppyczko , @miquelalzanillas please review.