Repository navigation
[18.0][FIX] currency_rate_update_xe: Obtain the values without locks + tests - #241
Merged
OCA-git-bot merged 2 commits intoOct 19, 2026
Merged
Conversation
xe.com started blocking requests without a User-Agent header around May 2025, returning HTTP 403 which silently produced empty rate results. Add a browser User-Agent, call raise_for_status() so errors surface as a proper UserError, and switch the base URL to HTTPS. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
victoralmau
marked this pull request as draft
October 19, 2026 11:48
OCA-git-bot
added
mod:currency_rate_update_xe
victoralmau
marked this pull request as ready for review
October 19, 2026 11:58
2 tasks
pedrobaeza
approved these changes
Oct 19, 2026
sergio-teruel
approved these changes
Oct 19, 2026
Member
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 8aea867. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseed #234
Obtain the values without locks + tests
Please @pedrobaeza and @sergio-teruel can you review it?
@Tecnativa TT65060