feat(recorder): improve automatic recording lifecycle - #126
Open
YetheSamartaka wants to merge 3 commits into
Open
feat(recorder): improve automatic recording lifecycle#126YetheSamartaka wants to merge 3 commits into
YetheSamartaka wants to merge 3 commits into
Conversation
Added: - Auto-restart and connection event buffering - New CBA settings to configure everything these changes are touching Changed: - Player counting and Steam ID handling
Author
|
Linked with OCAP2/extension#202 |
thegamecracks
suggested changes
Aug 22, 2026
thegamecracks
left a comment
thegamecracks
left a comment
Contributor
There was a problem hiding this comment.
Small review from me since I noticed old code removed by #125 came back up, despite not triggering a merge conflict :)
Co-authored-by: thegamecracks <61257169+thegamecracks@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added:
Changed: