Repository navigation
Fix concept-code lookups containing slashes - #13
Merged
Merged
Conversation
Release version 1.6.0 with FHIR-to-OMOP concept resolution features
Release version 1.7.0 with new FHIR resolution features
Prep for 1.7.0
Add FHIR Resolution section to pkgdown documentation
Add FHIR Resolution section to pkgdown documentation
v1.8.0 prep
v1.9.0 prep
Release v1.9.1
konstjar
force-pushed
the
codex/fix-by-code-path-encoding
branch
from
September 21, 2026 15:50
f8d1372 to
a38f82d
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 3 reviewed files. 1 file intentionally excluded from review.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Node SDK was also rechecked: its production code already uses encodeURIComponent for both segments and its current test suite already covers a slash-containing concept code, so no Node change is needed.
Validation
Summary by cubic
Fixes concept-code lookups in the R SDK so codes containing slashes (e.g., ICD-O code
8032/3) resolve correctly, including when hierarchy, synonym, relationship, or vocabulary-release query options are set.get_by_codenow percent-encodes the vocabulary ID and concept code as individual URL path segments and treats literal percent sequences as literal segment input. The request builder preserves that encoding instead of letting query updates decode it.This mirrors the Node SDK and adds regression tests covering the encoded request path with and without query options.
Written for commit b718fbd. Summary will update on new commits.