Conversation
A required check that only runs sometimes cannot be satisfied the rest of the time.
ci: run the basename check on every pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
developtomain, so the change is live for the tools that read this repository and somaincarries the workflow.What is in it
#9 — removes the
paths:filters fromcheck-query-names.yml, and rewrites the comment that justified the rule.The rule had been justified by the web application keying a lookup table by each file's basename. That was the query-library form mode, which has since been dropped. The rule is worth keeping on its own terms, and the comment now says so: the
.sparqlfiles are a shared pool that several tools draw from, and a filename is how a query is referred to outside the index that lists it.Why main needs it, not just develop
check-basenamesis about to be made a required check on both branches. A required check that does not run cannot be satisfied — the pull request waits for a status that never arrives. Any branch cut frommainwould be in that position if the workflow lived only ondevelop.Note on the histories
developandmainhave identical trees but divergent histories: four earlierdevelop → mainmerges were never brought back, sodevelopis not a descendant ofmain. This merge reconnects them, and future release pull requests will show only real changes rather than those four as noise.Nothing else changes
No query is added, removed or edited.
web-library.yamlis untouched.