Conversation
The repository has a test suite and no check running it, so a pull request could merge with it failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same two workflows as #123, which targets
develop. They are needed onmainas well, and the reason is not symmetry.Why main needs them too
A hotfix is cut from
main. When a hotfix pull request is opened, GitHub builds the merge commit from the hotfix branch andmain— so if the workflows live only ondevelop, neither side has them, neither check ever runs, and with the checks required the hotfix cannot merge. To fix that you would have to switch protection off, at exactly the moment you are trying to ship an urgent fix.Putting them on
mainnow means every branch cut from it carries them.What they are
tests—npm cithennpm test, Node 20, on every pull request and on pushes tomainanddevelop.guard main— fails when a pull request intomaincomes from a branch that is neitherrelease/*norhotfix/*, with an error saying to go throughdevelopand a release instead.Neither is path-filtered: a required check that only runs sometimes cannot be satisfied the rest of the time.
Checked
mainpasses its own suite: 290 tests.test/guard-should-blockand passed one fromrelease/guard-test. Both were closed unmerged.hotfix/*, so the guard should pass on it.