Test-DISMFromOSDCloudUSB always enumerates to True for Lenovo devices

[skyblaster]

When testing on a Lenovo and the following folder is present, the Test-DISMFromOSDCloudUSB function enumerates to True, even though a $ComputerProduct sub folder does not exist:
E:\OSDCloud\DriverPacks\DISM\Lenovo\

This is due to "PackageID": null, statements in the Lenovo DriverPack Catalog

Causing line 30 to fail to complete the path:

OSD/Public/OSDCloudTS/Test-DISMFromOSDCloudUSB.ps1

Line 30 in 809ff2d

$DriverPathPackageID = "$($OSDCloudDriveLetter):\OSDCloud\DriverPacks\DISM\$ComputerManufacturer\$PackageID"

And line 41 to return True

OSD/Public/OSDCloudTS/Test-DISMFromOSDCloudUSB.ps1

Line 41 in 809ff2d

elseif (Test-Path $DriverPathPackageID){Return $true}

[skyblaster]

Further testing on a Dell Latitude 5400, the following folder produces a True result:
E:\OSDCloud\DriverPacks\DISM\Dell\08B8\

Whereas the following PackageID folder results in False:
E:\OSDCloud\DriverPacks\DISM\Dell\84RYJ\

I'm not sure how to explain this one at the moment.

[skyblaster]

To resolve the PackageID issue for HP and Dell, the following two lines simply need to be reversed:

OSD/Public/OSDCloudTS/Test-DISMFromOSDCloudUSB.ps1

Lines 24 to 25 in 809ff2d

	$PackageID = $DriverPack.PackageID
	$DriverPack = Get-OSDCloudDriverPack -Product $ComputerProduct

[gwblok]

Thanks @skyblaster, Sorry, been away from my computer for awhile, and still will be barely around for a bit.
Thanks for spotting that issue with lines 24 & 25 switched.

Is this entire things resolved now, or are you still having some issues?
My test pool of Lenovo devices isn't good. I have a T480 laptop.

Let me know if you're still having issues and I'll put it on my list to look into.

Glad someone is using this feature, I've been loving it, but 95% of my testing is on HP devices, and it's been working well.

[skyblaster]

Thanks @gwblok. I believe the merge resolves the issue completely, so I'll close the issue now.

I'll do more testing once it's been pushed to the PSGallery. If I happened to break anything I'll open a new issue and hopefully another PR to fix.

[gwblok]

@skyblaster , thanks so much for being on top of that and digging through the code.
With the new baby, and taking care of the other 8 kids, I've been a bit overwhelmed. This is my first night on my computer in the last week!